-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual workflow for tagged versions #136
Manual workflow for tagged versions #136
Conversation
Signed-off-by: Carlo Lobrano <[email protected]>
Signed-off-by: Carlo Lobrano <[email protected]>
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clobrano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bundle/manifests/fence-agents-remediation.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few small comments, other than that, it looks very nice!
Signed-off-by: Carlo Lobrano <[email protected]>
Signed-off-by: Carlo Lobrano <[email protected]>
Signed-off-by: Carlo Lobrano <[email protected]>
- removed unnecessary skip_range_lower input - correctly log the other inputs Signed-off-by: Carlo Lobrano <[email protected]>
Signed-off-by: Carlo Lobrano <[email protected]>
3fd8f51
to
1c4cd22
Compare
/lgtm |
@clobrano: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
E2E tests do not test the changes of this PR. Can merge without them. |
Why we need this PR
FAR CI uses the post-release workflow for building and pushing versioned bundle images, however, the workflow cannot guess the right PREVIOUS_VERSION (when it is necessary) and it would publish manifests with wrong value of the
.spec.replaces
field.Changes made
post-release
to therelease
workflow, which supports manual inputs such has PREVIOUS_VERSIONrelease
workflow with the latest version of Medik8s shared workflow to build and push community bundlesspec.replaces
field only in OKD bundleTest plan
Tested locally with nektos/act
ECOPROJECT-1579