Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual workflow for tagged versions #136

Merged
merged 7 commits into from
Apr 2, 2024

Conversation

clobrano
Copy link
Contributor

@clobrano clobrano commented Mar 27, 2024

Why we need this PR

FAR CI uses the post-release workflow for building and pushing versioned bundle images, however, the workflow cannot guess the right PREVIOUS_VERSION (when it is necessary) and it would publish manifests with wrong value of the .spec.replaces field.

Changes made

  • Move build and push images job from the post-release to the release workflow, which supports manual inputs such has PREVIOUS_VERSION
  • Integrated the release workflow with the latest version of Medik8s shared workflow to build and push community bundles
  • Set spec.replaces field only in OKD bundle

Test plan

Tested locally with nektos/act

ECOPROJECT-1579

Copy link
Contributor

openshift-ci bot commented Mar 27, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@clobrano clobrano requested a review from razo7 March 27, 2024 10:59
@clobrano clobrano self-assigned this Mar 27, 2024
Makefile Show resolved Hide resolved
Copy link
Member

@razo7 razo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few small comments, other than that, it looks very nice!

.github/workflows/post-submit.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
- removed unnecessary skip_range_lower input
- correctly log the other inputs

Signed-off-by: Carlo Lobrano <[email protected]>
Signed-off-by: Carlo Lobrano <[email protected]>
@clobrano clobrano force-pushed the automate-rh-community-bundle-0 branch from 3fd8f51 to 1c4cd22 Compare March 27, 2024 15:29
@razo7
Copy link
Member

razo7 commented Apr 2, 2024

/lgtm

@razo7 razo7 marked this pull request as ready for review April 2, 2024 11:44
@openshift-ci openshift-ci bot requested review from beekhof and mshitrit April 2, 2024 11:44
Copy link
Contributor

openshift-ci bot commented Apr 2, 2024

@clobrano: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.12-openshift-e2e 1c4cd22 link true /test 4.12-openshift-e2e
ci/prow/4.15-openshift-e2e 1c4cd22 link true /test 4.15-openshift-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clobrano
Copy link
Contributor Author

clobrano commented Apr 2, 2024

E2E tests do not test the changes of this PR. Can merge without them.

@clobrano clobrano merged commit 77358e0 into medik8s:main Apr 2, 2024
19 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants