Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build a file-based catalog #138

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

clobrano
Copy link
Contributor

@clobrano clobrano commented Apr 5, 2024

Why we need this PR

Currently FAR Makefile creates a db-based catalog, which was deprecated

DEPRECATION NOTICE:
Sqlite-based catalogs and their related subcommands are deprecated. Support for
them will be removed in a future release. Please migrate your catalog workflows
to the new file-based catalog format.

Changes made

This change create a file-based catalog

https://docs.openshift.com/container-platform/4.14/operators/admin/olm-managing-custom-catalogs.html#olm-managing-custom-catalogs-fb

Which issue(s) this PR fixes

https://issues.redhat.com/browse/ECOPROJECT-1947

Test plan

  • create the file-based catalog and push it to my quay.io repository via Makefile
  • create a CatalogSource pointing to the new catalog
  • install FAR via WebUI, verify that everything works

Signed-off-by: Carlo Lobrano <[email protected]>
Copy link
Contributor

openshift-ci bot commented Apr 5, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved label Apr 5, 2024
@clobrano
Copy link
Contributor Author

clobrano commented Apr 8, 2024

e2e tests won't test this change, so there is no need to run them

Makefile Outdated Show resolved Hide resolved
@razo7
Copy link
Member

razo7 commented Apr 9, 2024

/lgtm
Left one nit though

@openshift-ci openshift-ci bot added the lgtm label Apr 9, 2024
Co-authored-by: Or Raz <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Apr 9, 2024
@razo7
Copy link
Member

razo7 commented Apr 9, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 9, 2024
@razo7 razo7 marked this pull request as ready for review April 9, 2024 06:40
@openshift-ci openshift-ci bot requested review from mshitrit and razo7 April 9, 2024 06:40
@clobrano
Copy link
Contributor Author

/retest

@clobrano
Copy link
Contributor Author

/approve

@razo7
Copy link
Member

razo7 commented Apr 14, 2024

All the tests are green and I think only the tide job hasn't been activated. Maybe we should restart the jobs with /retest

Copy link
Contributor

openshift-ci bot commented Apr 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, mshitrit, razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [clobrano,mshitrit,razo7]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@clobrano clobrano merged commit e2a5486 into medik8s:main Apr 15, 2024
21 checks passed
@clobrano clobrano deleted the move-to-file-based-catalog-0 branch April 15, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants