Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run bundle in test target to ensure bundle is up to date #140

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

slintes
Copy link
Member

@slintes slintes commented Apr 8, 2024

Why we need this PR

The current tests does not check if the bundle directory is up to date.

Changes made

Added bundle-reset target to test target.

Which issue(s) this PR fixes

n/a

Test plan

tested locally with a temporary change to an API field description

@slintes
Copy link
Member Author

slintes commented Apr 8, 2024

/test 4.15-test

1 similar comment
@slintes
Copy link
Member Author

slintes commented Apr 9, 2024

/test 4.15-test

@slintes
Copy link
Member Author

slintes commented Apr 9, 2024

/test 4.15-test

@razo7
Copy link
Member

razo7 commented Apr 9, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 9, 2024
@slintes
Copy link
Member Author

slintes commented Apr 9, 2024

just to be sure, running one e2e test...

/test 4.15-openshift-e2e

@slintes
Copy link
Member Author

slintes commented Apr 9, 2024

e2e CI is broken atm...

@slintes slintes marked this pull request as ready for review April 12, 2024 07:51
@openshift-ci openshift-ci bot requested a review from razo7 April 12, 2024 07:51
@slintes
Copy link
Member Author

slintes commented Apr 12, 2024

/retest

1 similar comment
@slintes
Copy link
Member Author

slintes commented Apr 12, 2024

/retest

@slintes
Copy link
Member Author

slintes commented Apr 12, 2024

trying to wake up tide...

/skip

@slintes
Copy link
Member Author

slintes commented Apr 12, 2024

/skip

@slintes
Copy link
Member Author

slintes commented Apr 12, 2024

/override ci/prow/4.12-test

Copy link
Contributor

openshift-ci bot commented Apr 12, 2024

@slintes: Overrode contexts on behalf of slintes: ci/prow/4.12-test

In response to this:

/override ci/prow/4.12-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@slintes
Copy link
Member Author

slintes commented Apr 12, 2024

/approve cancel

@openshift-ci openshift-ci bot removed the approved label Apr 12, 2024
@slintes
Copy link
Member Author

slintes commented Apr 12, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Apr 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@slintes slintes merged commit e285b25 into medik8s:main Apr 12, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants