Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Scorecard testing in Makefile #141

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Conversation

razo7
Copy link
Member

@razo7 razo7 commented Apr 9, 2024

Add Scorecard testing for FAR on GitHub CI and a Kubernetes kind cluster.

Why we need this PR

Scorecard testing extends our CI for bundle verification.

Changes made

  • Makefile target for running the scorecard test
  • Kind config
  • New GitHub CI which uses the new target and kind config to set a Kubernetes cluster, and to run the scorecard testing (it initiates config maps and pods for the tests)
  • FIx for bundle-reset target

Which issue(s) this PR fixes

Similar PR to NMO #129

Create makefile target for CI
Scorecard testing requires a running Kubernetes cluster
No need to reset creation date after it was reset in the bundle target
Copy link
Contributor

openshift-ci bot commented Apr 9, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved label Apr 9, 2024
Copy link
Contributor

@clobrano clobrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Giving a chance to get-more reviews
/hold

@razo7
Copy link
Member Author

razo7 commented Apr 14, 2024

/retest
/unhold

Copy link
Contributor

openshift-ci bot commented Apr 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@razo7
Copy link
Member Author

razo7 commented Apr 16, 2024

Merging manually for now due to a possible problem with tide

@razo7 razo7 merged commit ec0c8f6 into medik8s:main Apr 16, 2024
22 checks passed
@razo7 razo7 deleted the scorecard-testing-far branch April 16, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants