Update docs with the new remediationStrategy spec #145
Conversation
Signed-off-by: Carlo Lobrano <[email protected]>
|
Skipping CI for Draft Pull Request. |
clobrano
changed the title
Signed-off-by: Carlo Lobrano <[email protected]>
bundle/manifests/fence-agents-remediation.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Carlo Lobrano <[email protected]>
clobrano
force-pushed
the
update-readme-out-of-service-taint-0
branch
from
7c38251
to
a2de242
Compare
Signed-off-by: Carlo Lobrano <[email protected]>
clobrano
force-pushed
the
update-readme-out-of-service-taint-0
branch
from
a2de242
to
3ff441e
Compare
Signed-off-by: Carlo Lobrano <[email protected]>
Signed-off-by: Carlo Lobrano <[email protected]>
|
/test 4.16-openshift-e2e |
The error doesn't seem our fault. Retrying /test 4.16-openshift-e2e |
|
/retest |
1 similar comment
|
/retest |
|
/retest |
|
/test 4.12-openshift-e2e |
|
/test 4.14-openshift-e2e |
README.md
Outdated
| @@ -192,6 +192,9 @@ The CR includes the following parameters: | |||
| * `retrycount` - number of times to retry the fence agent in case of failure. The default is 5. | |||
| * `retryinterval` - interval between retries in seconds. The default is "5s". | |||
| * `timeout` - timeout for the fence agent in seconds. The default is "60s". | |||
| * `remediationStrategy` - either `ResourceDeletion` or `OutOfServiceTaint`: | |||
| * `ResourceDeletion`: This remediation strategy removes the pods on the node. | |||
There was a problem hiding this comment.
Maybe it's me only, but why don't we call things how they are called already? 🤔
Here: we do not remove anything, we delete them... that's the actual method name we use. That's the D in CRUD. 🤷🏼♂️ (Same below)
(and I don't block on this, just a general thought, which I had more often at various places)
There was a problem hiding this comment.
/lgtm
in case you want to change...
/hold
There was a problem hiding this comment.
why don't we call things how they are called already
for me, I think it's just an automatic mechanism to avoid repetitions in written documents, but indeed when explaining something this habit can be limited :)
Use "delete" in place of "remove" as it is more appropriate, and put Out-of-service taint first in the list. Signed-off-by: Carlo Lobrano <[email protected]>
|
/test 4.13-openshift-e2e |
|
/test 4.16-openshift-e2e |
|
/unhold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clobrano, razo7, slintes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Why we need this PR
FAR CR has a new spec field
remediationStrategy(see #92)Changes made
Add the documentation about the new FAR remediation's spec field
remediationStrategy