Fix release workflow job #146
Conversation
Remove the condition on github.ref_type in "Create release with manifests" job, which prevent the Github release to be completed with the usual document. Signed-off-by: Carlo Lobrano <[email protected]>
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clobrano, slintes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This PR does not need e2e tests /override "ci/prow/4.14-openshift-e2e" |
|
@clobrano: Overrode contexts on behalf of clobrano: ci/prow/4.14-openshift-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override "ci/prow/4.15-openshift-e2e" |
|
@clobrano: Overrode contexts on behalf of clobrano: ci/prow/4.15-openshift-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
The first time it just aborted the test, which resulted in a failure /override "ci/prow/4.15-openshift-e2e" |
|
@clobrano: Overrode contexts on behalf of clobrano: ci/prow/4.15-openshift-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Why we need this PR
Currently, the "Create release with manifests" step in the release CI Job is wrongly conditioned under a specific value of github.ref_type ('tag').
This is a leftover of the recent rework and prevent the relece CI to publish the release manifest on GitHub.
Changes made
Remove the condition from "Create release with manifests" step
Which issue(s) this PR fixes
Test plan
This change can be tested only once it is merged, unfortunately.