Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort-imports Tool #15

Merged
merged 2 commits into from
Feb 21, 2023
Merged

sort-imports Tool #15

merged 2 commits into from
Feb 21, 2023

Conversation

razo7
Copy link
Member

@razo7 razo7 commented Feb 21, 2023

  • Add two targets for sort-imports Tool
  • Apply fix-imports changes

Sort Go imports according to our best practices (separated by an empty line)
Overwrite source files with fixed imports
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@clobrano
Copy link
Contributor

Nice Idea to use it as part of the tooling 👍

@clobrano
Copy link
Contributor

/lgtm
Giving others a chance to review as well, feel free to unhold
/hold

@slintes
Copy link
Member

slintes commented Feb 21, 2023

🙂

/hold cancel

@openshift-merge-robot openshift-merge-robot merged commit 9117160 into medik8s:main Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants