Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend FAR Readme #22

Merged
merged 3 commits into from
Mar 20, 2023
Merged

Conversation

razo7
Copy link
Member

@razo7 razo7 commented Mar 13, 2023

Includes better and up to date information regarding background, installation, usage, and tests.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@razo7 razo7 changed the title [WIP] FAR Readme skeleton [WIP] Extend FAR Readme Mar 19, 2023
FAR background, API, and introduce two usage options
Latest from quay or build from source
@razo7 razo7 changed the title [WIP] Extend FAR Readme Extend FAR Readme Mar 19, 2023
sharedparameters:
--username: "admin"
--password: "password"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature request: allow this value to be kept in a k8s secret

@beekhof
Copy link
Contributor

beekhof commented Mar 20, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 20, 2023
@openshift-merge-robot openshift-merge-robot merged commit 4885b7c into medik8s:main Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants