CRD & CSV update #23
Merged
CRD & CSV update #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
razo7
commented
Mar 19, 2023
razo7
commented
- Add CRD and CR short names
- Update FAR CRD fields
- Update CSV description
Shorter name to search for CRD and running CRs of FAR and FART
Corrections
Include background and usage options
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: razo7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mshitrit
reviewed
Mar 20, 2023
| @@ -45,6 +45,8 @@ type FenceAgentsRemediationTemplateStatus struct { | |||
|
|
|||
| // +kubebuilder:object:root=true | |||
| // +kubebuilder:subresource:status | |||
| //+kubebuilder:resource:scope=Cluster,shortName=fart | |||
There was a problem hiding this comment.
I know it's stupid, but that one makes me laugh every time, I think it's great 😂
|
/lgtm |
|
/lgtm Giving a chance to get more feedbacks, feel free to unhold |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.