Build FAR with flags #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: razo7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
razo7
commented
Mar 20, 2023
razo7
force-pushed
the
build-FAR-with-parameters
branch
2 times, most recently
from
f88b8df
to
8c1abd5
Compare
Informative information mainly for downstream
New build method for FAR
razo7
force-pushed
the
build-FAR-with-parameters
branch
from
8c1abd5
to
2de1456
Compare
Should fix the inconsistent vendoring problem for running make build
Git will be used in hack/build.sh to get the git commit and operator's version
razo7
force-pushed
the
build-FAR-with-parameters
branch
from
bbffc17
to
9844784
Compare
|
/lgtm Giving a chance to get more feedbacks, feel free to unhold |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align FAR with other Medik8s operators with the use of
hack/build.shto build FAR operator with 5 fields on the build: