Dummy e2e Test #29
Dummy e2e Test #29
Conversation
Using Ginkgo commands to bootsrap a new suite - e2e
Test that the dummy CR has been created
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: razo7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
test/e2e/far_e2e_test.go
Outdated
| "github.com/medik8s/fence-agents-remediation/api/v1alpha1" | ||
| ) | ||
|
|
||
| const fenceAgentDummy = "echo" |
There was a problem hiding this comment.
(very) nit: I think the name of this variable could be more descriptive. Is it the Agent name?
There was a problem hiding this comment.
Nit: IMO var value could be better (i.e for example dummy-fence-agent)
There was a problem hiding this comment.
echo is just an example to dummy-fence-agent and I doubt it would run without a failure. In the end a pod will try to run a cli command dummy-fence-agent, and I have used echo since it is very basic Unix-like operating system command.
test/e2e/far_e2e_test.go
Outdated
| }) | ||
| }) | ||
|
|
||
| // createFAR assigns the input to FenceAgentsRemediation object, creates CR it with offset, and returns the CR object |
There was a problem hiding this comment.
is there a maybe a typo here? "creates CR it with offset"
There was a problem hiding this comment.
Nit: IIUC the offset refers to the error reporting and not the CR creation
There was a problem hiding this comment.
Correct I will fix it in a follow up
test/e2e/far_e2e_test.go
Outdated
| }) | ||
|
|
||
| // createFAR assigns the input to FenceAgentsRemediation object, creates CR it with offset, and returns the CR object | ||
| func createFAR(nodeName string, agent string, sharedparameters map[v1alpha1.ParameterName]string, nodeparameters map[v1alpha1.ParameterName]map[v1alpha1.NodeName]string) *v1alpha1.FenceAgentsRemediation { |
There was a problem hiding this comment.
Use camel case naming format might be helpful
nodeParameters, sharedParameters
|
/lgtm |
|
/unhold |
Basic and dummy E2E test which only creates CR, verify it was created and then deletes it. The FAR CR is not running any FA, and only echo an empty string ->
echo " "This way we can catch installation/running errors, such as #26, because deployment would fail until we add functionality of E2E test in #20.