Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Medik8s icon for FAR #37

Merged
merged 2 commits into from
Apr 17, 2023
Merged

Conversation

razo7
Copy link
Member

@razo7 razo7 commented Apr 17, 2023

Adding an icon for FAR is needed, since bundle validation in #27 fails (while #35 only raised a warning on bundle validation).
ATM we use Medik8s icon, since it is only the first release of FAR and we might change it in the future.

We do provide two icon versions for better identification between upstream and downstream operators - we use blue icons upstream and red icons for downstream.

Since FAR is still a tech preview, thus we use Medik8s logo. We also add a red version for midstream/downstream usage, and we convert the icon to base 64 only when bundle-update is used (in bundle-build target
Trigger bundle-update target, and append Community Edition suffix to displayName
@openshift-ci openshift-ci bot requested review from beekhof and slintes April 17, 2023 13:10
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@razo7
Copy link
Member Author

razo7 commented Apr 17, 2023

/cherry-pick release-0.1

@openshift-cherrypick-robot

@razo7: once the present PR merges, I will cherry-pick it on top of release-0.1 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@clobrano
Copy link
Contributor

/lgtm

@openshift-cherrypick-robot

@razo7: new pull request created: #38

In response to this:

/cherry-pick release-0.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants