Use Kubernetes Recommended Label for commonLabels #46
Conversation
The recommended labels describe objects in a common manner that all tools can understand
Update bundle directory
|
Another commonLabel that we might also consider of using is |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: razo7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm Giving a chance to get more feedbacks, feel free to unhold |
There was a problem hiding this comment.
This will probably fail updates, see comment here: https://github.com/medik8s/node-healthcheck-operator/blob/main/config/default/kustomization.yaml#L13
Please check if that issue still exists. If so, you also need to change the name 🤷🏼
razo7
changed the title
|
/retest |
|
Merging. Updates from a pre-GA version that lacks resource deletion is not a priority |
|
Just for the record, the update issue with modified labels (if it still exists in OLM) can easily be worked around by changing the deployment name. Just in case we want to make Tech Preview users happy 🙂 |
Changing FAR's label from
app: fence-agents-remediation-operatortoapp.kubernetes.io/name: fence-agents-remediation-operator, since it is one of Kubernetes recommended labels for commonLabels.