Apply PSA Changes #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
slintes
requested changes
May 10, 2023
Drop all capabilites and add seccompProfile to comply with PSA changes from K8s v1.25
Missed from CI on PR medik8s#45
slintes
approved these changes
May 11, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: razo7, slintes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closed
razo7
added a commit
to razo7/fence-agents-remediation
that referenced
this pull request
Jun 8, 2023
The E2E test is redundant after medik8s#47 PR, and it also fails here when we try to add/remove taint for a node which doesn't exist - dummy-node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following NMO's PR to comply with Kubernetes v1.25 PSA changes we drop all the capabilities for the
managercontainer.We also add the
seccompProfile.type: RuntimeDefaultby default, unlike for NMO, since it has been tested and deployed from OCP 4.11+.Related docs: