Update Ginkgo to GinkgoV2 #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ginkgo v1.16.5 is the last Ginkgo v1 release, Oct 2021, before bumping to a new major release which has been introduced on 2022. Ginkgo v2.9.5 is the latest version and it has been releasd on May 2023.
Not supported in Ginkgo v2
Ginkgo v2 supports different naming for flags
Add missing and remove unused modules, make vendored copy of dependencies, and verify dependencies have expected content
If multiple values are returned by the function, Eventually will pass the first value to the matcher and require that all others are zero-valued
|
/retest |
1 similar comment
|
/retest |
slintes
approved these changes
May 30, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: razo7, slintes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finish ECOPROJECT-820