-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support and Handle Taints #53
Merged
openshift-merge-robot
merged 9 commits into
medik8s:main
from
razo7:remediation-NoExecute-taint
Jun 19, 2023
Merged
Support and Handle Taints #53
openshift-merge-robot
merged 9 commits into
medik8s:main
from
razo7:remediation-NoExecute-taint
Jun 19, 2023
Commits on Jun 18, 2023
-
Declaring remediation taint with NoExecute effect to drain pods and not schedule them again on the unhealthy node
Configuration menu - View commit details
-
Copy full SHA for 229bdbb - Browse repository at this point
Copy the full SHA 229bdbbView commit details -
Add finalizer to remove taints
Remove node taint when a CR is about to be deleted using a finalizer
Configuration menu - View commit details
-
Copy full SHA for 10a8eac - Browse repository at this point
Copy the full SHA 10a8eacView commit details -
We need to add two new rbac rules: delete, and patch for adding and removing taint on a cluster node
Configuration menu - View commit details
-
Copy full SHA for 1cb27b5 - Browse repository at this point
Copy the full SHA 1cb27b5View commit details -
The E2E test is redundant after medik8s#48 PR, and it also fails here when we try to add/remove taint for a node which doesn't exist - dummy-node
Configuration menu - View commit details
-
Copy full SHA for 34739a6 - Browse repository at this point
Copy the full SHA 34739a6View commit details -
Use unique remediation/NoExecute taint key for FAR
Apparently a taint is considered unique by key:effect, reagrdless of the taint's value - if the two taints share the same key:effect. then are considered equal. We modify the taint's key to be unique and not similar to SNR's remediation taint
Configuration menu - View commit details
-
Copy full SHA for b50afc4 - Browse repository at this point
Copy the full SHA b50afc4View commit details -
Use Update rather than Patch for updating node taints
The API server is updating taints as well while nodes get healthy/unhealthy, so patch can overwrite changes made by API server
Configuration menu - View commit details
-
Copy full SHA for 3e02d9b - Browse repository at this point
Copy the full SHA 3e02d9bView commit details -
Validate CR/node prior to adding/removing finalizer and taints
When CR/node is invalid. then there is no need to add/remove finalizer and taints
Configuration menu - View commit details
-
Copy full SHA for 753a064 - Browse repository at this point
Copy the full SHA 753a064View commit details -
Configuration menu - View commit details
-
Copy full SHA for c18caf9 - Browse repository at this point
Copy the full SHA c18caf9View commit details
Commits on Jun 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 36c3ebf - Browse repository at this point
Copy the full SHA 36c3ebfView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.