Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support and Handle Taints #53

Merged
merged 9 commits into from
Jun 19, 2023

Commits on Jun 18, 2023

  1. Add remediation taint

    Declaring remediation taint with NoExecute effect to drain pods and not schedule them again on the unhealthy node
    razo7 committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    229bdbb View commit details
    Browse the repository at this point in the history
  2. Add finalizer to remove taints

    Remove node taint when a CR is about to be deleted using a finalizer
    razo7 committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    10a8eac View commit details
    Browse the repository at this point in the history
  3. Add verbs for nodes resources

    We need to add two new rbac rules: delete, and patch for adding and removing taint on a cluster node
    razo7 committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    1cb27b5 View commit details
    Browse the repository at this point in the history
  4. Remove redundant E2E test

    The E2E test is redundant after medik8s#48 PR, and it also fails here when we try to add/remove taint for a node which doesn't exist - dummy-node
    razo7 committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    34739a6 View commit details
    Browse the repository at this point in the history
  5. Use unique remediation/NoExecute taint key for FAR

    Apparently a taint is considered unique by key:effect, reagrdless of the taint's value -  if the two taints share the same key:effect. then are considered equal. We modify the taint's key to be unique and not similar to SNR's remediation taint
    razo7 committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    b50afc4 View commit details
    Browse the repository at this point in the history
  6. Use Update rather than Patch for updating node taints

    The API server is updating taints as well while nodes get healthy/unhealthy, so patch can overwrite changes made by API server
    razo7 committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    3e02d9b View commit details
    Browse the repository at this point in the history
  7. Validate CR/node prior to adding/removing finalizer and taints

    When CR/node is invalid. then there is no need to add/remove finalizer and taints
    razo7 committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    753a064 View commit details
    Browse the repository at this point in the history
  8. Check if finalizer and taints exist

    Test it on valid and invalid CRs
    razo7 committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    c18caf9 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2023

  1. Minor cleanup in ut var names

    Share variables and lowercase var name
    razo7 committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    36c3ebf View commit details
    Browse the repository at this point in the history