Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize Reboot Test Pod Warnings of PSA #65

Merged

Conversation

razo7
Copy link
Member

@razo7 razo7 commented Jul 5, 2023

The reboot test pod needs privilage permissions for fetching the node's boot time, and these permissions can be minimized.

The reboot test pod needs privilage permissions for fetching the node's boot time, and these permissions can be minimized
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 5, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jul 5, 2023
@razo7
Copy link
Member Author

razo7 commented Jul 5, 2023

/test 4.13-openshift-e2e

@razo7
Copy link
Member Author

razo7 commented Jul 17, 2023

/test 4.14-openshift-e2e

@mshitrit
Copy link
Member

/test ?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 17, 2023

@mshitrit: The following commands are available to trigger required jobs:

  • /test 4.12-ci-index
  • /test 4.12-images
  • /test 4.12-openshift-e2e
  • /test 4.13-ci-index
  • /test 4.13-images
  • /test 4.13-openshift-e2e
  • /test 4.14-ci-index
  • /test 4.14-images
  • /test 4.14-openshift-e2e

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mshitrit
Copy link
Member

/lgtm
/hold
giving others chance to review

@clobrano
Copy link
Contributor

/lgtm

Giving a chance to get more feedbacks, feel free to unhold
/hold

@razo7 razo7 marked this pull request as ready for review July 23, 2023 14:11
@openshift-ci openshift-ci bot requested review from clobrano and mshitrit July 23, 2023 14:11
@razo7
Copy link
Member Author

razo7 commented Jul 24, 2023

#68 is going to use the test pod and for stooping Kubelet HostPID: true should be defined in the spec of the testing pod. Thus I am revering this change.

@razo7 razo7 force-pushed the minimize-reboot-test-pod-warnings branch from 69972b6 to c3a8f6a Compare July 24, 2023 09:55
@openshift-ci openshift-ci bot removed the lgtm label Jul 24, 2023
@mshitrit
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 26, 2023
@razo7
Copy link
Member Author

razo7 commented Jul 26, 2023

\unhold

@razo7
Copy link
Member Author

razo7 commented Jul 26, 2023

/unhold

@openshift-merge-robot openshift-merge-robot merged commit 1fd1a5d into medik8s:main Jul 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants