Add priorityClassName to the Manager Container

[razo7]

Help the scheduler to understand the pod's priority versus other pods to be scheduled.

priorityClassName for other Medik8s operators:

• NHC - system-cluster-critical
• NMO - system-cluster-critical
• SNR - system-cluster-critical

Related links:

• Pod Priority in Kubernetes - https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/#pod-priority
• priorityClassName in OpenShift - https://docs.openshift.com/container-platform/latest/nodes/pods/nodes-pods-priority.html
• Three priorityClassName conventions - https://github.com/openshift/enhancements/blob/master/CONVENTIONS.md#priority-classes

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[razo7]

/test 4.13-openshift-e2e

[razo7]

/test 4.13-openshift-e2e

[mshitrit]

Hmm looking at the 3 Three priorityClassName conventions I'm not entirely sure whether system-node-critical or system-cluster-critical is more appropriate here.
As far as I see the only difference is that the latter one can be OOMKilled, which IIUC shouldn't happen as long as it's not using more memory than declared.

• Am I getting it right ?
• Any particular reason for choosing system-cluster-critical over system-node-critical ?

[slintes]

we should discuss this more, tbh I doubt that system-cluster-critical or system-node-critical should be used by non core OCP components.

/hold

[razo7]

Am I getting it right ?

👍🏻

Any particular reason for choosing system-cluster-critical over system-node-critical ?

Consistency with the other operators, since they use system-cluster-critical.

In the last team meeting we have discussed about this topic and AFAIU using system-cluster-critical, as the other operators use, is the less strict priorityClassName out of the two common Kubernetes PriorityClasses and it suits FAR.

[slintes]

/hold cancel

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [razo7,slintes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment