Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Group Name to fence-agents-remediation #7

Merged
merged 4 commits into from
Jan 30, 2023

Conversation

razo7
Copy link
Member

@razo7 razo7 commented Jan 23, 2023

  • Switching from fence-agents to fence-agents-remediation files
  • Create new bundle directory with updated Medik8s fields (e.g., provider)
  • Apply fence-agents to fence-agents-remediation group changes in medik8s.io domain

Copy link
Contributor

@clobrano clobrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 23, 2023
@openshift-ci openshift-ci bot removed the lgtm label Jan 23, 2023
@razo7 razo7 changed the title Refactor Group Name Refactor Group Name to fence-agents-remediation Jan 23, 2023
@razo7 razo7 force-pushed the refactor-group-name branch 3 times, most recently from 690dca9 to f80d6b0 Compare January 23, 2023 15:39
Copy link
Contributor

@clobrano clobrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm
/lgtm
Giving others a chance to review as well, feel free to unhold
/hold

:)

@clobrano
Copy link
Contributor

/lgtm
Giving others a chance to review as well, feel free to unhold
/hold

@clobrano
Copy link
Contributor

/lgtm
Giving others a chance to review as well, feel free to unhold
/hold

@openshift-ci openshift-ci bot added the lgtm label Jan 26, 2023
@openshift-ci openshift-ci bot removed the lgtm label Jan 29, 2023
@mshitrit
Copy link
Member

/lgtm

@slintes
Copy link
Member

slintes commented Jan 30, 2023

/hold cancel

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 1d0978a into medik8s:main Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants