Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish FAR to Stable Channel #71

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

razo7
Copy link
Member

@razo7 razo7 commented Jul 30, 2023

Getting ready to new release and with the workload deletion logic FAR can be subscribed published to the stable channel.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 30, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Getting ready to new release and with the workload deletion logic FAR can be subscribed to the `stable` channel
@razo7
Copy link
Member Author

razo7 commented Jul 30, 2023

/test 4.13-openshift-e2e

@razo7
Copy link
Member Author

razo7 commented Jul 31, 2023

I think the channel in CI should be updated as well (OO_CHANNEL: candidate).

@slintes
Copy link
Member

slintes commented Jul 31, 2023

I think the channel in CI should be updated as well (OO_CHANNEL: candidate).

yes!

Also: we do not "subscribe" here, we "publish" in a channel 🙂

@razo7 razo7 changed the title Subscribe FAR to Stable Channel Publish FAR to Stable Channel Jul 31, 2023
@razo7
Copy link
Member Author

razo7 commented Aug 1, 2023

CI will pass only after openshift/release#41861 is merged

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@razo7 razo7 marked this pull request as ready for review August 2, 2023 09:06
@openshift-ci openshift-ci bot requested review from beekhof and slintes August 2, 2023 09:06
@razo7
Copy link
Member Author

razo7 commented Aug 2, 2023

/retest

4 similar comments
@razo7
Copy link
Member Author

razo7 commented Aug 2, 2023

/retest

@razo7
Copy link
Member Author

razo7 commented Aug 2, 2023

/retest

@slintes
Copy link
Member

slintes commented Aug 2, 2023

/retest

@razo7
Copy link
Member Author

razo7 commented Aug 3, 2023

/retest

@razo7
Copy link
Member Author

razo7 commented Aug 3, 2023

I am unsure why VA was not been deleted on the first e2e test on OCP 4.12. I am pretty confident that it is unrelated to the PR change.
/retest

@razo7
Copy link
Member Author

razo7 commented Aug 3, 2023

/retest

@openshift-merge-robot openshift-merge-robot merged commit b256c1b into medik8s:main Aug 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants