Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve verifyStatusCondition Function Readability & Gomega Expect Update #73

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Improve verifyStatusCondition Function Readability & Gomega Expect Update #73

merged 2 commits into from
Aug 14, 2023

Conversation

razo7
Copy link
Member

@razo7 razo7 commented Aug 2, 2023 •
edited
Loading

  • Discard an error.go file and improve the usage of verifyStatusCondition for non existing status condition or expected value is different than actual value
  • Pass an explicit instance of Gomega Expect to the Eventually/Consistently functions- for more see in Gomega docs.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 2, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved label Aug 2, 2023
@openshift-ci openshift-ci bot added the lgtm label Aug 2, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@razo7 razo7 marked this pull request as ready for review August 2, 2023 10:43
@slintes
Copy link
Member

slintes commented Aug 9, 2023

/retest

1 similar comment
@razo7
Copy link
Member Author

razo7 commented Aug 11, 2023

/retest

@razo7
Improve verifyStatusCondition func readability
1c29246 
Discard an error.go file and usage of verifyStatusCondition for non existing status condition or expected value is different than actual value
@razo7
Gomega Expect change after Ginkgo v2
78a67e4 
Pass an explicit instance to the Eventually/Consistently functions
@openshift-ci openshift-ci bot removed the lgtm label Aug 13, 2023
@razo7
Copy link
Member Author

razo7 commented Aug 13, 2023

Due to channel change from the last merged PR I have rebased the PR

@razo7
Copy link
Member Author

razo7 commented Aug 13, 2023

/retest

2 similar comments
@razo7
Copy link
Member Author

razo7 commented Aug 13, 2023

/retest

@razo7
Copy link
Member Author

razo7 commented Aug 13, 2023

/retest

@slintes
Copy link
Member

slintes commented Aug 14, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 14, 2023
@openshift-merge-robot openshift-merge-robot merged commit 6ae766f into medik8s:main Aug 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slintes slintes slintes approved these changes

@clobrano clobrano Awaiting requested review from clobrano

@mshitrit mshitrit Awaiting requested review from mshitrit

Assignees

@slintes slintes

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@razo7 @slintes @openshift-merge-robot