Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match Condition Message to Variable Name #78

Merged

Conversation

razo7
Copy link
Member

@razo7 razo7 commented Aug 23, 2023

Condition message didn't match the variable name.
Correct condition message between Node not found and NHC time out scenarios

…narios

Condition message didn't match the variable name
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@razo7
Copy link
Member Author

razo7 commented Aug 23, 2023

/test 4.13-openshift-e2e
/test 4.14-openshift-e2e

Copy link
Member

@slintes slintes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this is why I try to avoid using production consts in tests 😉

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@razo7 razo7 marked this pull request as ready for review August 23, 2023 12:16
@openshift-ci openshift-ci bot requested review from beekhof and slintes August 23, 2023 12:16
@razo7
Copy link
Member Author

razo7 commented Aug 23, 2023

/retest

@openshift-merge-robot openshift-merge-robot merged commit 4f00ec5 into medik8s:main Aug 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants