Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FenceAgentSucceededConditionMessage Condition Message #85

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Fix FenceAgentSucceededConditionMessage Condition Message #85

merged 1 commit into from
Oct 3, 2023

Conversation

razo7
Copy link
Member

@razo7 razo7 commented Sep 28, 2023 •
edited
Loading

Missing and the in the condition message.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 28, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@razo7
Copy link
Member Author

razo7 commented Sep 28, 2023

/test 4.13-openshift-e2e
/test 4.14-openshift-e2e

clobrano
clobrano reviewed Sep 28, 2023
View reviewed changes
api/v1alpha1/fenceagentsremediation_types.go Outdated
@@ -34,7 +34,7 @@ const (
RemediationFinishedNodeNotFoundConditionMessage = "FAR CR name doesn't match a node name"
RemediationInterruptedByNHCConditionMessage = "Node Healthcheck timeout annotation has been set"
RemediationStartedConditionMessage = "FAR CR was found, its name matches one of the cluster nodes, and a finalizer was set to the CR"
FenceAgentSucceededConditionMessage = "FAR taint was added, fence agent command has been created and executed successfully"
FenceAgentSucceededConditionMessage = "FAR taint was added, and fence agent command has been created and executed successfully"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I think you don't need the comma here, it is not a series of things, where usually the Oxford comma is used.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks better?

@razo7
Copy link
Member Author

razo7 commented Oct 2, 2023

/test 4.13-openshift-e2e
/test 4.14-openshift-e2e
/test 4.15-openshift-e2e

@clobrano
Copy link
Contributor

clobrano commented Oct 2, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 2, 2023
@razo7 razo7 marked this pull request as ready for review October 2, 2023 10:58
@razo7
Copy link
Member Author

razo7 commented Oct 2, 2023

/retest

1 similar comment
@razo7
Copy link
Member Author

razo7 commented Oct 3, 2023

/retest

@openshift-ci openshift-ci bot merged commit efe5906 into medik8s:main Oct 3, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clobrano clobrano Awaiting requested review from clobrano

@mshitrit mshitrit Awaiting requested review from mshitrit

Assignees

@clobrano clobrano

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@razo7 @clobrano