Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fence-azure-arm agent #91

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

jcanocan
Copy link
Contributor

Currently, if the agent fence_azure_arm is used, FAR throws an error showing that the fence_azure_arm is not found. It adds the Azure fence agent.

Fix: #90

Currently, if the agent fence_azure_arm is used, FAR throws an error
showing that the `fence_azure_arm` is not found. It adds the Azure fence
agent.

Signed-off-by: Javier Cano Cano <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2023

Hi @jcanocan. Thanks for your PR.

I'm waiting for a medik8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@razo7
Copy link
Member

razo7 commented Oct 12, 2023

/ok-to-test

@razo7
Copy link
Member

razo7 commented Oct 15, 2023

/retest
/approve
Even though using the fence-azure-arm agent won't work due to a known bug, with the ClusterLabs/fence-agents#562 fix it should work.
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcanocan, razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 90a975b into medik8s:main Oct 15, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to fence nodes with fence_azure_arm agent
2 participants