Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fence_gce Agent for GCP #95

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Add fence_gce Agent for GCP #95

merged 1 commit into from
Nov 16, 2023

Conversation

razo7
Copy link
Member

@razo7 razo7 commented Oct 17, 2023

Adding a fence agent for Google Cloud Platform (GCP) platform - fence_gce

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@razo7 razo7 changed the title Add fence_gce for GCP Add fence_gce agent for GCP Oct 17, 2023
@razo7 razo7 changed the title Add fence_gce agent for GCP Add fence_gce Agent for GCP Oct 17, 2023
@razo7
Add fence_gce
64a53e7 
Adding a fence agent for GCP platform - fence_gce
@clobrano
Copy link
Contributor

clobrano commented Nov 9, 2023

/lgtm
out of curiosity, how big the image would result after this addition?
/hold
feel free to unhold

@razo7 razo7 marked this pull request as ready for review November 12, 2023 04:50
@razo7
Copy link
Member Author

razo7 commented Nov 12, 2023

/retest

@razo7
Copy link
Member Author

razo7 commented Nov 13, 2023

out of curiosity, how big the image would result after this addition?

Before it was 159.7 MiB, and with the new agent it is 160.9 MiB, so the new image is only adding 1.2 MiB.

/unhold

@razo7
Copy link
Member Author

razo7 commented Nov 14, 2023

/retest

2 similar comments
@razo7
Copy link
Member Author

razo7 commented Nov 14, 2023

/retest

@razo7
Copy link
Member Author

razo7 commented Nov 16, 2023

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit c81afe0 into medik8s:main Nov 16, 2023
18 checks passed
@razo7 razo7 deleted the add-fence-gce branch January 7, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beekhof beekhof Awaiting requested review from beekhof

@slintes slintes Awaiting requested review from slintes

Assignees

@clobrano clobrano

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@razo7 @clobrano