-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable HTTP/2 in metrics server #97
Conversation
Signed-off-by: Carlo Lobrano <[email protected]>
Signed-off-by: Carlo Lobrano <[email protected]>
Signed-off-by: Carlo Lobrano <[email protected]>
Disable HTTP/2 to avoid CVE HTTP/2 Rapid reset see https://issues.redhat.com/browse/ECOPROJECT-1739 Signed-off-by: Carlo Lobrano <[email protected]>
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clobrano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/reset |
flaky test /cherry-pick release-0.2 |
@razo7: once the present PR merges, I will cherry-pick it on top of release-0.2 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@razo7: Overrode contexts on behalf of razo7: ci/prow/4.13-openshift-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@razo7: new pull request created: #98 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Disable HTTP/2 in Metric server to avoid CVE HTTP/2 Rapid Reset.
Currently, the metrics server enables/disables HTTP/2 support only if
SecureServing is enabled, which is not. However this change adds the
disabling logic anyway to avoid future issues.
see https://issues.redhat.com/browse/ECOPROJECT-1738