Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable HTTP/2 in metrics server #97

Merged
merged 4 commits into from
Oct 22, 2023

Conversation

clobrano
Copy link
Contributor

Disable HTTP/2 in Metric server to avoid CVE HTTP/2 Rapid Reset.

Currently, the metrics server enables/disables HTTP/2 support only if
SecureServing is enabled, which is not. However this change adds the
disabling logic anyway to avoid future issues.

see https://issues.redhat.com/browse/ECOPROJECT-1738

Signed-off-by: Carlo Lobrano <[email protected]>
Disable HTTP/2 to avoid CVE HTTP/2 Rapid reset

see https://issues.redhat.com/browse/ECOPROJECT-1739

Signed-off-by: Carlo Lobrano <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@clobrano clobrano marked this pull request as ready for review October 20, 2023 08:32
@slintes
Copy link
Member

slintes commented Oct 20, 2023

/lgtm

@razo7
Copy link
Member

razo7 commented Oct 22, 2023

/reset

@razo7
Copy link
Member

razo7 commented Oct 22, 2023

flaky test
/override ci/prow/4.13-openshift-e2e

/cherry-pick release-0.2
/lgtm

@openshift-cherrypick-robot

@razo7: once the present PR merges, I will cherry-pick it on top of release-0.2 in a new PR and assign it to you.

In response to this:

flaky test
/override ci/prow/4.13-openshift-e2e

/cherry-pick release-0.2
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 22, 2023

@razo7: Overrode contexts on behalf of razo7: ci/prow/4.13-openshift-e2e

In response to this:

flaky test
/override ci/prow/4.13-openshift-e2e

/cherry-pick release-0.2
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot merged commit 236f52d into medik8s:main Oct 22, 2023
18 checks passed
@openshift-cherrypick-robot

@razo7: new pull request created: #98

In response to this:

flaky test
/override ci/prow/4.13-openshift-e2e

/cherry-pick release-0.2
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants