-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up Golang using go.mod file #76
Set up Golang using go.mod file #76
Conversation
Needed for running `test` target and use go.mod and go.sum files
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: razo7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I remember a similar PR in NMO, where Marc also updated the Dockerfile to ensure the go version was the same as defined in |
I can add the Dockerfile change. Do you want me to add the CI |
I don't know what is the effect of that file 😅 |
IIUC the Usually we use Golang base image as build images and we modify it in CI, after we have changed our code Golang version. By using the FYI MDR already use this file - https://github.com/medik8s/machine-deletion-remediation/blob/main/.ci-operator.yaml |
One less place to update Golang version
/lgtm |
/retest |
6 similar comments
/retest |
/retest |
/retest |
/retest |
/retest |
/retest |
Save time and possible errors of updating Golang version by fetching it from go.mod file: