-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Node providerID to metric #236
Conversation
Add Node providerID to NodeHealthCheckUnhealthyNodeDuration metric. While node name might change after a remediation that deletes the node (e.g. with Machine-Deletion-Remediation), the ProviderID is expected to be the same, allowing users to query for the complete history of the same node after such remediations. NOTE: ProviderID is expected to change anyway in case of Cloud cluster providers. Signed-off-by: Carlo Lobrano <[email protected]>
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clobrano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test ? |
@clobrano: The following commands are available to trigger required jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test 4.14-openshift-e2e |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@clobrano: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Add Node providerID to NodeHealthCheckUnhealthyNodeDuration metric.
While node name might change after a remediation that deletes the node
(e.g. with Machine-Deletion-Remediation), the ProviderID is expected to
be the same, allowing users to query for the complete history of the
same node after such remediations.
NOTE: ProviderID is expected to change anyway in case of Cloud cluster
providers.
ECOPROJECT-1479