Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Node providerID to metric #236

Closed

Conversation

clobrano
Copy link
Contributor

@clobrano clobrano commented Jul 28, 2023

Add Node providerID to NodeHealthCheckUnhealthyNodeDuration metric.

While node name might change after a remediation that deletes the node
(e.g. with Machine-Deletion-Remediation), the ProviderID is expected to
be the same, allowing users to query for the complete history of the
same node after such remediations.

NOTE: ProviderID is expected to change anyway in case of Cloud cluster
providers.

ECOPROJECT-1479

Add Node providerID to NodeHealthCheckUnhealthyNodeDuration metric.

While node name might change after a remediation that deletes the node
(e.g. with Machine-Deletion-Remediation), the ProviderID is expected to
be the same, allowing users to query for the complete history of the
same node after such remediations.

NOTE: ProviderID is expected to change anyway in case of Cloud cluster
providers.

Signed-off-by: Carlo Lobrano <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@clobrano
Copy link
Contributor Author

/test ?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2023

@clobrano: The following commands are available to trigger required jobs:

  • /test 4.11-ci-bundle-my-bundle
  • /test 4.11-images
  • /test 4.11-openshift-e2e
  • /test 4.11-test
  • /test 4.12-ci-bundle-my-bundle
  • /test 4.12-images
  • /test 4.12-openshift-e2e
  • /test 4.12-test
  • /test 4.13-ci-bundle-my-bundle
  • /test 4.13-images
  • /test 4.13-openshift-e2e
  • /test 4.13-test
  • /test 4.14-ci-bundle-my-bundle
  • /test 4.14-images
  • /test 4.14-openshift-e2e
  • /test 4.14-test

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@clobrano
Copy link
Contributor Author

/test 4.14-openshift-e2e

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2023

@clobrano: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.15-test 4c03125 link true /test 4.15-test
ci/prow/4.15-ci-bundle-my-bundle 4c03125 link true /test 4.15-ci-bundle-my-bundle
ci/prow/4.15-images 4c03125 link true /test 4.15-images
ci/prow/4.15-openshift-e2e 4c03125 link true /test 4.15-openshift-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clobrano clobrano closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants