Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add display property on leave or unpublish event #3426

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

amnonbb
Copy link
Contributor

@amnonbb amnonbb commented Sep 16, 2024

As title say. If it's not doing problem somewhere it's help to get display property in event as it's done in other places.

@atoppi
Copy link
Member

atoppi commented Sep 16, 2024

Just to double check since it is not being mentioned: this is for the kicked / unpublished / leaving event emitted to the event handlers, so unrelated to the Janus API event.

@lminiero
Copy link
Member

Good catch: is that what you meant to do @amnonbb?

@amnonbb
Copy link
Contributor Author

amnonbb commented Sep 17, 2024

Good catch: is that what you meant to do @amnonbb?

Yes. it is. Almost in all places we got display property except kicked / unpublished / leaving

@amnonbb
Copy link
Contributor Author

amnonbb commented Sep 18, 2024

Just to double check since it is not being mentioned: this is for the kicked / unpublished / leaving event emitted to the event handlers, so unrelated to the Janus API event.

Sorry, now i understood what you ask. Event handlers is where i used it and keep fork only for this change. But generally may be right to add it in Janus API event as well.

@lminiero
Copy link
Member

@amnonbb looks good to me! Could you also update the documentation of the impacted events, though, to clarify there could be a display property too now?

@lminiero
Copy link
Member

Thanks, merging! I'll consider if porting the same patch to 0.x as well.

@lminiero lminiero merged commit 12c5487 into meetecho:master Oct 18, 2024
8 checks passed
spscream pushed a commit to spscream/janus-gateway that referenced this pull request Oct 24, 2024
natikaltura pushed a commit to natikaltura/janus-gateway that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants