-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add display property on leave or unpublish event #3426
Conversation
Just to double check since it is not being mentioned: this is for the |
Good catch: is that what you meant to do @amnonbb? |
Yes. it is. Almost in all places we got display property except kicked / unpublished / leaving |
Sorry, now i understood what you ask. Event handlers is where i used it and keep fork only for this change. But generally may be right to add it in Janus API event as well. |
@amnonbb looks good to me! Could you also update the documentation of the impacted events, though, to clarify there could be a |
Thanks, merging! I'll consider if porting the same patch to 0.x as well. |
As title say. If it's not doing problem somewhere it's help to get display property in event as it's done in other places.