Skip to content
This repository has been archived by the owner on Dec 23, 2018. It is now read-only.

A button to toggle the addon on/off #27

Closed
ReporterX opened this issue Apr 19, 2015 · 6 comments
Closed

A button to toggle the addon on/off #27

ReporterX opened this issue Apr 19, 2015 · 6 comments

Comments

@ReporterX
Copy link

I know there is an addon called "Custom Buttons", but the button image does not change when you toggle the addon on and off.
It is still a hassle to users if they need to add this basic function themselves.
Sometimes we need to switch it off when you visit a website which has complicated referer checking.
It is better to provide a button by the addon itself, instead of seeking help from a third-party addon.

@ntninja
Copy link
Collaborator

ntninja commented Apr 19, 2015

Ping @meh
Please look into this :-)

@ntninja
Copy link
Collaborator

ntninja commented Jun 17, 2015

@meh Would you accept a pull request that implements this?

@meh
Copy link
Owner

meh commented Jun 17, 2015

@Alexander255 if it doesn't make the code way more complex because of XUL or whatever, sure.

@ntninja
Copy link
Collaborator

ntninja commented Jun 19, 2015

Is it OK if I'm loading the button via the Add-on SDK? The existing code would have to be ported to a SDK module, but the changes to the existing code would be minimal nevertheless. I'd estimate about 50 to 200 extra lines of code. Would that be OK with you?

@meh
Copy link
Owner

meh commented Jun 19, 2015

Ehhh, that much code for just a button sounds lame.

Would you be able to add some UI stuff for the whitelist too? If that's the case I'd be okay with that increase.

ntninja added a commit that referenced this issue Jan 9, 2017
Most stuff was rewritten and (if possible) simplified, the only truely original piece of code is the
policy engine that processes the whitelist entries.

Also contains a newly "designed" logo that is used for the toolbar icon requested #27.
ntninja added a commit that referenced this issue Jan 9, 2017
Also features a new "logo" for Smart Referer.
ntninja added a commit that referenced this issue Jan 9, 2017
Also features a new "logo" for Smart Referer.
@ntninja
Copy link
Collaborator

ntninja commented Apr 17, 2017

Fixed by our switch to WebExtensions (#48)

@ntninja ntninja closed this as completed Apr 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants