test: 🧪 refactor some tests

mehdihadeli · Sep 15, 2024 · 5a52242 · 5a52242
1 parent 5baeff1
commit 5a52242
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 6 deletions.
diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
@@ -107,7 +107,8 @@
         "vscode-icons-team.vscode-icons",
         "csharpier.csharpier-vscode",
         "redhat.vscode-yaml",
-        "kennylong.kubernetes-yaml-formatter"
+        "kennylong.kubernetes-yaml-formatter",
+        "sonarsource.sonarlint-vscode"
       ]
     }
   },

diff --git a/.github/actions/app-version/action.yml b/.github/actions/app-version/action.yml
@@ -132,7 +132,7 @@ runs:
 
     - name: Upload Version Artifact
       if: success()
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       with:
         name: ${{ inputs.service-name}}_version_artifacts
         path: version_name.txt
diff --git a/.github/actions/docker-build-push/action.yml b/.github/actions/docker-build-push/action.yml
@@ -94,7 +94,7 @@ runs:
 
     - name: Upload artifact
       if: success()
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       with:
         name: ${{ inputs.service-name}}_image_artifacts
         path: image_name.txt
diff --git a/.github/actions/publish-app/action.yml b/.github/actions/publish-app/action.yml
@@ -85,7 +85,7 @@ runs:
       run: ls -R ${{ github.workspace }}/output
 
     - name: Upload Publish Services Artifacts For Deployment Jobs
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       if: success()
       with:
         name: ${{ inputs.service-name}}_publish_artifacts

diff --git a/.github/actions/test-coverage/action.yml b/.github/actions/test-coverage/action.yml
@@ -68,7 +68,7 @@ runs:
       # https://github.blog/changelog/2020-10-08-github-actions-ability-to-change-retention-days-for-artifacts-and-logs/
       # https://github.com/actions/upload-artifact#upload-an-entire-directory
     - name: Upload Test And Coverage Results Artifacts
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       if: steps.test-results-zip.outcome == 'success'
       with:
         name: ${{ inputs.service-name}}_test_artifacts

diff --git a/.github/workflows/reusable-build-test-push.yml b/.github/workflows/reusable-build-test-push.yml
@@ -188,7 +188,7 @@ jobs:
 
       - name: Upload CD Status artifact
         if: success()
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
            name: ${{ inputs.service-name}}_cd_status_artifacts
            path: cd_status.txt