Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: ✅ add some test fixes #242

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,8 @@
"vscode-icons-team.vscode-icons",
"csharpier.csharpier-vscode",
"redhat.vscode-yaml",
"kennylong.kubernetes-yaml-formatter"
"kennylong.kubernetes-yaml-formatter",
"sonarsource.sonarlint-vscode"
]
}
},
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/app-version/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ runs:

- name: Upload Version Artifact
if: success()
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: ${{ inputs.service-name}}_version_artifacts
path: version_name.txt
2 changes: 1 addition & 1 deletion .github/actions/docker-build-push/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ runs:

- name: Upload artifact
if: success()
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: ${{ inputs.service-name}}_image_artifacts
path: image_name.txt
2 changes: 1 addition & 1 deletion .github/actions/publish-app/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ runs:
run: ls -R ${{ github.workspace }}/output

- name: Upload Publish Services Artifacts For Deployment Jobs
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: success()
with:
name: ${{ inputs.service-name}}_publish_artifacts
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/test-coverage/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ runs:
# https://github.blog/changelog/2020-10-08-github-actions-ability-to-change-retention-days-for-artifacts-and-logs/
# https://github.com/actions/upload-artifact#upload-an-entire-directory
- name: Upload Test And Coverage Results Artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: steps.test-results-zip.outcome == 'success'
with:
name: ${{ inputs.service-name}}_test_artifacts
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/reusable-build-test-push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ jobs:

- name: Upload CD Status artifact
if: success()
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: ${{ inputs.service-name}}_cd_status_artifacts
path: cd_status.txt
Loading