Update crypto statement to fix vite issue #1652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tragio
reviewed
May 14, 2024
brunoocasali
force-pushed
the
crypto-fix
branch
2 times, most recently
from
27480d2
to
df8e9dd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1652 +/- ##
==========================================
- Coverage 97.54% 97.43% -0.12%
==========================================
Files 22 22
Lines 857 858 +1
Branches 93 93
==========================================
Hits 836 836
- Misses 20 22 +2
+ Partials 1 0 -1 ☔ View full report in Codecov by Sentry. |
|
I tried this branch with the repo to reproduce the issue https://github.com/flexchar/meili-issue-1299 and it works! |
Tragio
approved these changes
May 14, 2024
meili-bors bot
added a commit
that referenced
this pull request
May 15, 2024
1653: Update version for the next release (v0.40.0) r=curquiza a=meili-bot - Fix the issue introduced in the v0.39 that affected vite apps #1652 `@brunoocasali` - Now to use the `generateTenantToken` you should use it with `await`: before: ```js const token = client.generateTenantToken(apiKeyUid, searchRules, { apiKey: apiKey, expiresAt: expiresAt, }) ``` after: ```js const token = await client.generateTenantToken(apiKeyUid, searchRules, { apiKey: apiKey, expiresAt: expiresAt, }) ``` Co-authored-by: meili-bot <[email protected]>
This was referenced Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the introduction of this PR #1616 we had a bunch of issues related to vite configuration on client projects as shown here meilisearch/meilisearch-js-plugins#1299
This PR introduces the rollback needed to fix the consumer's code. If this change is not enough, I will completely reverse the PR 1616.
Edit:
I was able to solve the issue, by using this branch with this reproduction repo I could build the project and also run the application without any issue.
But this change introduces some breaking changes in the JWT code:
Now it is required to use await:
await client.generateTenantToken(..)instead of justclient.generateTenantToken(..).