Support search in facet values #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyprx
force-pushed
the
feat/facet-search
branch
from
59dbc64
to
b1bb215
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #839 +/- ##
==========================================
+ Coverage 92.13% 92.20% +0.07%
==========================================
Files 13 13
Lines 776 783 +7
==========================================
+ Hits 715 722 +7
Misses 61 61
☔ View full report in Codecov by Sentry. |
Co-authored-by: Paul Sanders <[email protected]>
Co-authored-by: Paul Sanders <[email protected]>
3 tasks
|
bors merge |
meili-bors bot
added a commit
that referenced
this pull request
Sep 11, 2023
841: Bump github actions checkout to v4 r=curquiza a=sanders41 # Pull Request GitHub Actions are currently failing across multiple repositories with network issues. the checkout action is currently having issues with this, issue [here](actions/checkout#1448), and bumping to the newly released v4 seems to be helping. This action is not the only thing that is having issues with the network problems so we could still see failures until it is resolved, but bumping to v4 is at least helping with the checkout part. These network issues are also what keep causing #839 to fail. ## Related issue Fixes #<issue_number> ## What does this PR do? - Bumps checkout to v4 ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: Paul Sanders <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #830
What does this PR do?
facet_searchwhich performs search in facet valuesPR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!