Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Rust version in Clippy job #3451

Merged
merged 4 commits into from
Feb 6, 2023
Merged

Pin Rust version in Clippy job #3451

merged 4 commits into from
Feb 6, 2023

Conversation

curquiza
Copy link
Member

@curquiza curquiza commented Feb 2, 2023

Avoid "surprising" CI failure because of clippy when rust is releasing a new version

@curquiza curquiza added this to the v1.1.0 milestone Feb 2, 2023
@curquiza curquiza added maintenance Issue about maintenance (CI, tests, refacto...) github actions Pull requests that update GitHub Actions code labels Feb 2, 2023
@curquiza
Copy link
Member Author

curquiza commented Feb 2, 2023

⚠️ Do not merge before the @Kerollmops approval

@curquiza curquiza marked this pull request as ready for review February 2, 2023 14:35
Copy link
Contributor

@dureuill dureuill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love that!

Suggested some typo fixes, now let's wait for @Kerollmops' review :-)

.github/workflows/create-issue-dependencies.yml Outdated Show resolved Hide resolved
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of like that, can we setup a reminder bot or will we remember to update it on our own?
bors merge

bors bot added a commit that referenced this pull request Feb 6, 2023
3451: Pin Rust version in Clippy job r=Kerollmops a=curquiza

Avoid "surprising" CI failure because of clippy when rust is releasing a new version

Co-authored-by: curquiza <[email protected]>
Co-authored-by: Clémentine Urquizar - curqui <[email protected]>
@bors
Copy link
Contributor

bors bot commented Feb 6, 2023

Build failed:

@dureuill
Copy link
Contributor

dureuill commented Feb 6, 2023

¯\(ツ)

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 6, 2023

Build succeeded:

@bors bors bot merged commit fadea50 into main Feb 6, 2023
@bors bors bot deleted the pin-rust-version-in-clippy branch February 6, 2023 12:56
@curquiza
Copy link
Member Author

curquiza commented Feb 7, 2023

@Kerollmops
You can see in the PR I updated our automation to not forget to update the Rust version

@curquiza curquiza mentioned this pull request Mar 13, 2023
@meili-bot meili-bot added the v1.1.0 PRs/issues solved in v1.1.0 released on 2023-04-03 label Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github actions Pull requests that update GitHub Actions code maintenance Issue about maintenance (CI, tests, refacto...) v1.1.0 PRs/issues solved in v1.1.0 released on 2023-04-03
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants