Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitely drop the search permits #4898

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

irevoire
Copy link
Member

Pull Request

Related issue

May be related to #4654 and https://github.com/meilisearch/meilisearch-support/issues/350

What does this PR do?

  • Stop spawning a tokio task that is not immediately scheduled and instead explicitly drop the search permit

This should make new search requests to be scheduled quicker than before and reduce the general load on tokio

@irevoire irevoire added the enhancement New feature or improvement label Aug 28, 2024
@irevoire irevoire added this to the v1.10.1 milestone Aug 28, 2024
Copy link
Member

@ManyTheFish ManyTheFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Copy link
Contributor

meili-bors bot commented Aug 28, 2024

@meili-bors meili-bors bot merged commit 541a23b into release-v1.10.1 Aug 28, 2024
10 checks passed
@meili-bors meili-bors bot deleted the explicitely-drop-search-permit branch August 28, 2024 14:19
@meili-bot meili-bot added the v1.10.1 PRs/issues solved in v1.10.1 label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement v1.10.1 PRs/issues solved in v1.10.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants