[Ingest Manager] Prevent closing closed reader (elastic#20214)

* prevent closing closed * changelog
melchiormoulin · Oct 14, 2020 · efdf7f1 · efdf7f1
1 parent 6a4d94b
commit efdf7f1
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/x-pack/elastic-agent/CHANGELOG.asciidoc b/x-pack/elastic-agent/CHANGELOG.asciidoc
@@ -54,6 +54,7 @@
 - Unzip failures on Windows 8/Windows server 2012 {pull}20088[20088]
 - Fix failing unit tests on windows {pull}20127[20127]
 - Improve GRPC stop to be more relaxed {pull}20118[20118]
+- Prevent closing closed reader {pull}20214[20214]
 
 ==== New features
 

diff --git a/x-pack/elastic-agent/pkg/agent/application/info/agent_id.go b/x-pack/elastic-agent/pkg/agent/application/info/agent_id.go
@@ -94,10 +94,6 @@ func getInfoFromStore(s ioStore) (*persistentAgentInfo, error) {
 			errors.M(errors.MetaKeyPath, agentConfigFile))
 	}
 
-	if err := reader.Close(); err != nil {
-		return nil, err
-	}
-
 	configMap, err := cfg.ToMapStr()
 	if err != nil {
 		return nil, errors.New(err,
@@ -137,10 +133,6 @@ func updateAgentInfo(s ioStore, agentInfo *persistentAgentInfo) error {
 			errors.M(errors.MetaKeyPath, agentConfigFile))
 	}
 
-	if err := reader.Close(); err != nil {
-		return err
-	}
-
 	configMap := make(map[string]interface{})
 	if err := cfg.Unpack(&configMap); err != nil {
 		return errors.New(err, "failed to unpack stored config to map")