Skip to content

Commit

Permalink
Change ItemType to object (GoogleCloudPlatform#10249)
Browse files Browse the repository at this point in the history
  • Loading branch information
zli82016 authored Mar 21, 2024
1 parent de6caa4 commit d62cd8a
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 19 deletions.
2 changes: 1 addition & 1 deletion mmv1/api/type.go
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ type Type struct {

EnumValues []string `yaml:"enum_values"`

ItemType string `yaml:"item_type"`
ItemType *Type `yaml:"item_type"`

Resource string

Expand Down
35 changes: 18 additions & 17 deletions mmv1/products/datafusion/go_instance.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -279,20 +279,21 @@ able to access the public internet."
If accelerators are enabled it is possible a permadiff will be created with the Options field.
Users will need to either manually update their state file to include these diffed options, or include the field in a [lifecycle ignore changes block](https://developer.hashicorp.com/terraform/language/meta-arguments/lifecycle#ignore_changes)."
item_type: NestedObject
properties:
- name: 'acceleratorType'
type: Enum
description: "The type of an accelator for a CDF instance."
required: true
enum_values:
- 'CDC'
- 'HEALTHCARE'
- 'CCAI_INSIGHTS'
- name: 'state'
type: Enum
description: "The type of an accelator for a CDF instance."
required: true
enum_values:
- 'ENABLED'
- 'DISABLED'
item_type:
properties:
- name: 'acceleratorType'
type: Enum
description: "The type of an accelator for a CDF instance."
required: true
enum_values:
- 'CDC'
- 'HEALTHCARE'
- 'CCAI_INSIGHTS'
- name: 'state'
type: Enum
description: "The type of an accelator for a CDF instance."
required: true
enum_values:
- 'ENABLED'
- 'DISABLED'
type: NestedObject
3 changes: 2 additions & 1 deletion mmv1/products/pubsub/go_Topic.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,8 @@ constraints are in effect."
allowed regions. An empty list means that no regions are allowed,
and is not a valid configuration."
required: true
item_type: Api::Type::String
item_type:
type: String
- name: 'schemaSettings'
type: NestedObject
description: "Settings for validating messages published against a schema."
Expand Down

0 comments on commit d62cd8a

Please sign in to comment.