Skip to content

Commit

Permalink
Address broken importlib.resources in Python 3.9
Browse files Browse the repository at this point in the history
  • Loading branch information
edgarrmondragon committed Jul 18, 2024
1 parent a7d9cd3 commit b3aaa84
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 8 deletions.
2 changes: 1 addition & 1 deletion poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ backports-datetime-fromisoformat = { version = ">=2.0.1", python = "<3.11" }
click = "~=8.0"
fs = ">=2.4.16"
importlib-metadata = {version = "<9.0.0", python = "<3.12"}
importlib-resources = {version = ">=5.12.0,!=6.2.0,!=6.3.0,!=6.3.1", python = "<3.9"}
importlib-resources = {version = ">=5.12.0,!=6.2.0,!=6.3.0,!=6.3.1", python = "<3.10"}
inflection = ">=0.5.1"
joblib = ">=1.3.0"
jsonpath-ng = ">=1.5.3"
Expand Down
2 changes: 1 addition & 1 deletion singer_sdk/helpers/_resources.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

from singer_sdk.helpers._compat import Traversable

if sys.version_info < (3, 9):
if sys.version_info < (3, 10):
import importlib_resources
else:
import importlib.resources as importlib_resources
Expand Down
6 changes: 1 addition & 5 deletions singer_sdk/metrics.py
Original file line number Diff line number Diff line change
Expand Up @@ -408,11 +408,7 @@ def _get_default_config_path(package: str) -> Traversable:
return path if path.is_file() else get_package_files("singer_sdk") / filename


def _setup_logging(
config: t.Mapping[str, t.Any],
*,
package: str | None = None,
) -> None:
def _setup_logging(config: t.Mapping[str, t.Any], *, package: str) -> None:
"""Setup logging.
Args:
Expand Down

0 comments on commit b3aaa84

Please sign in to comment.