feat: (WIP) Let developers more easily override SQL column type to JS…

…ON schema mapping

singer_sdk/connectors/sql.py

@@ -2,6 +2,7 @@
 
 from __future__ import annotations
 
+import functools
 import logging
 import typing as t
 import warnings
@@ -103,6 +104,56 @@ def prepare_part(self, part: str) -> str:  # noqa: PLR6301
         return part
 
 
+class SQLToJSONSchemaMap:
+    """SQLAlchemy to JSON Schema type mapping helper.
+
+    This class provides a mapping from SQLAlchemy types to JSON Schema types.
+    """
+
+    @functools.singledispatchmethod
+    def to_jsonschema(self, sa_type: sa.types.TypeEngine) -> dict:  # noqa: ARG002, PLR6301
+        """Return a JSON Schema representation of the provided type."""
+        return th.StringType.type_dict  # type: ignore[no-any-return]
+
+    @to_jsonschema.register
+    def datetime_to_jsonschema(self, sa_type: sa.types.DateTime) -> dict:  # noqa: ARG002, PLR6301
+        """Return a JSON Schema representation of a generic datetime type."""
+        return th.DateTimeType.type_dict  # type: ignore[no-any-return]
+
+    @to_jsonschema.register
+    def date_to_jsonschema(self, sa_type: sa.types.Date) -> dict:  # noqa: ARG002, PLR6301
+        """Return a JSON Schema representation of a date type."""
+        return th.DateType.type_dict  # type: ignore[no-any-return]
+
+    @to_jsonschema.register
+    def time_to_jsonschema(self, sa_type: sa.types.Time) -> dict:  # noqa: ARG002, PLR6301
+        """Return a JSON Schema representation of a time type."""
+        return th.TimeType.type_dict  # type: ignore[no-any-return]
+
+    @to_jsonschema.register
+    def integer_to_jsonschema(self, sa_type: sa.types.Integer) -> dict:  # noqa: ARG002, PLR6301
+        """Return a JSON Schema representation of a an integer type."""
+        return th.IntegerType.type_dict  # type: ignore[no-any-return]
+
+    @to_jsonschema.register
+    def float_to_jsonschema(self, sa_type: sa.types.Numeric) -> dict:  # noqa: ARG002, PLR6301
+        """Return a JSON Schema representation of a generic number type."""
+        return th.NumberType.type_dict  # type: ignore[no-any-return]
+
+    @to_jsonschema.register
+    def string_to_jsonschema(self, sa_type: sa.types.String) -> dict:  # noqa: ARG002, PLR6301
+        """Return a JSON Schema representation of a generic string type."""
+        # TODO: Enable support for maxLength.
+        # if sa_type.length:
+        #     return StringType(max_length=sa_type.length).type_dict  # noqa: ERA001
+        return th.StringType.type_dict  # type: ignore[no-any-return]
+
+    @to_jsonschema.register
+    def boolean_to_jsonschema(self, sa_type: sa.types.Boolean) -> dict:  # noqa: ARG002, PLR6301
+        """Return a JSON Schema representation of a boolean type."""
+        return th.BooleanType.type_dict  # type: ignore[no-any-return]
+
+
 class SQLConnector:  # noqa: PLR0904
     """Base class for SQLAlchemy-based connectors.
 
@@ -156,6 +207,17 @@ def logger(self) -> logging.Logger:
         """
         return logging.getLogger("sqlconnector")
 
+    @functools.cached_property
+    def type_mapping(self) -> SQLToJSONSchemaMap:
+        """Return the type mapper object.
+
+        Override this method to provide a custom mapping for your SQL dialect.
+
+        Returns:
+            The type mapper object.
+        """
+        return SQLToJSONSchemaMap()
+
     @contextmanager
     def _connect(self) -> t.Iterator[sa.engine.Connection]:
         with self._engine.connect().execution_options(stream_results=True) as conn:
@@ -260,8 +322,8 @@ def get_sqlalchemy_url(self, config: dict[str, t.Any]) -> str:  # noqa: PLR6301
 
         return t.cast(str, config["sqlalchemy_url"])
 
-    @staticmethod
     def to_jsonschema_type(
+        self,
         sql_type: (
             str  # noqa: ANN401
             | sa.types.TypeEngine
@@ -287,10 +349,25 @@ def to_jsonschema_type(
         Returns:
             The JSON Schema representation of the provided type.
         """
-        if isinstance(sql_type, (str, sa.types.TypeEngine)):
+        if isinstance(sql_type, sa.types.TypeEngine):
+            return self.type_mapping.to_jsonschema(sql_type)
+
+        if isinstance(sql_type, str):  # pragma: no cover
+            warnings.warn(
+                "Passing string types to `to_jsonschema_type` is deprecated. "
+                "Please pass a SQLAlchemy type object instead.",
+                DeprecationWarning,
+                stacklevel=2,
+            )
             return th.to_jsonschema_type(sql_type)
 
-        if isinstance(sql_type, type):
+        if isinstance(sql_type, type):  # pragma: no cover
+            warnings.warn(
+                "Passing type classes to `to_jsonschema_type` is deprecated. "
+                "Please pass a SQLAlchemy type object instead.",
+                DeprecationWarning,
+                stacklevel=2,
+            )
             if issubclass(sql_type, sa.types.TypeEngine):
                 return th.to_jsonschema_type(sql_type)
 

singer_sdk/typing.py

@@ -53,6 +53,7 @@
 from __future__ import annotations
 
 import json
+import sys
 import typing as t
 
 import sqlalchemy as sa
@@ -65,9 +66,13 @@
     get_datelike_property_type,
 )
 
-if t.TYPE_CHECKING:
-    import sys
+if sys.version_info < (3, 13):
+    from typing_extensions import deprecated
+else:
+    from typing import deprecated  # noqa: ICN003 # pragma: no cover
+
 
+if t.TYPE_CHECKING:
     from jsonschema.protocols import Validator
 
     if sys.version_info >= (3, 10):
@@ -1086,6 +1091,10 @@ def __iter__(self) -> t.Iterator[Property]:
         return self.wrapped.values().__iter__()
 
 
+@deprecated(
+    "Use `SQLToJSONSchemaMap` instead.",
+    category=DeprecationWarning,
+)
 def to_jsonschema_type(
     from_type: str | sa.types.TypeEngine | type[sa.types.TypeEngine],
 ) -> dict:
@@ -1119,9 +1128,9 @@ def to_jsonschema_type(
         "bool": BooleanType.type_dict,
         "variant": StringType.type_dict,
     }
-    if isinstance(from_type, str):
+    if isinstance(from_type, str):  # pragma: no cover
         type_name = from_type
-    elif isinstance(from_type, sa.types.TypeEngine):
+    elif isinstance(from_type, sa.types.TypeEngine):  # pragma: no cover
         type_name = type(from_type).__name__
     elif isinstance(from_type, type) and issubclass(
         from_type,

tests/core/test_connector_sql.py

@@ -11,7 +11,7 @@
 
 from samples.sample_duckdb import DuckDBConnector
 from singer_sdk.connectors import SQLConnector
-from singer_sdk.connectors.sql import FullyQualifiedName
+from singer_sdk.connectors.sql import FullyQualifiedName, SQLToJSONSchemaMap
 from singer_sdk.exceptions import ConfigValidationError
 
 if t.TYPE_CHECKING:
@@ -392,3 +392,55 @@ def prepare_part(self, part: str) -> str:
 def test_fully_qualified_name_empty_error():
     with pytest.raises(ValueError, match="Could not generate fully qualified name"):
         FullyQualifiedName()
+
+
+@pytest.mark.parametrize(
+    "sql_type, expected_jsonschema_type",
+    [
+        pytest.param(sa.types.VARCHAR(), {"type": ["string"]}, id="varchar"),
+        pytest.param(
+            sa.types.VARCHAR(length=127),
+            {"type": ["string"], "maxLength": 127},
+            marks=pytest.mark.xfail,
+            id="varchar-length",
+        ),
+        pytest.param(sa.types.TEXT(), {"type": ["string"]}, id="text"),
+        pytest.param(sa.types.INTEGER(), {"type": ["integer"]}, id="integer"),
+        pytest.param(sa.types.BOOLEAN(), {"type": ["boolean"]}, id="boolean"),
+        pytest.param(sa.types.DECIMAL(), {"type": ["number"]}, id="decimal"),
+        pytest.param(sa.types.FLOAT(), {"type": ["number"]}, id="float"),
+        pytest.param(sa.types.REAL(), {"type": ["number"]}, id="real"),
+        pytest.param(sa.types.NUMERIC(), {"type": ["number"]}, id="numeric"),
+        pytest.param(
+            sa.types.DATE(),
+            {"type": ["string"], "format": "date"},
+            id="date",
+        ),
+        pytest.param(
+            sa.types.DATETIME(),
+            {"type": ["string"], "format": "date-time"},
+            id="datetime",
+        ),
+        pytest.param(
+            sa.types.TIMESTAMP(),
+            {"type": ["string"], "format": "date-time"},
+            id="timestamp",
+        ),
+        pytest.param(
+            sa.types.TIME(),
+            {"type": ["string"], "format": "time"},
+            id="time",
+        ),
+        pytest.param(
+            sa.types.BLOB(),
+            {"type": ["string"]},
+            id="unknown",
+        ),
+    ],
+)
+def test_sql_to_json_schema_map(
+    sql_type: sa.types.TypeEngine,
+    expected_jsonschema_type: dict,
+):
+    m = SQLToJSONSchemaMap()
+    assert m.to_jsonschema(sql_type) == expected_jsonschema_type

tests/core/test_sql_typing.py

@@ -70,5 +70,7 @@ def test_convert_sql_type_to_jsonschema_type(
     sql_type: sa.types.TypeEngine,
     is_of_jsonschema_type: dict,
 ):
-    result = th.to_jsonschema_type(sql_type)
+    with pytest.warns(DeprecationWarning):
+        result = th.to_jsonschema_type(sql_type)
+
     assert result == is_of_jsonschema_type