Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid duplicate entries in required array of JSON schema helpers #1214

Merged
merged 6 commits into from
Dec 17, 2022

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Nov 22, 2022

Closes #1210


📚 Documentation preview 📚: https://meltano-sdk--1214.org.readthedocs.build/en/1214/

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #1214 (af3f9d0) into main (ee570e0) will not change coverage.
The diff coverage is 83.33%.

@@           Coverage Diff           @@
##             main    #1214   +/-   ##
=======================================
  Coverage   83.85%   83.85%           
=======================================
  Files          44       44           
  Lines        4150     4150           
  Branches      718      718           
=======================================
  Hits         3480     3480           
  Misses        490      490           
  Partials      180      180           
Impacted Files Coverage Δ
singer_sdk/typing.py 94.94% <83.33%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon marked this pull request as ready for review December 7, 2022 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants