feat: define a maxLength limit for varchar at the connector level #1812
Labels
Accepting Pull Requests
evergreen
good first issue
Good for newcomers
kind/Feature
New feature or request
SQL
Support for SQL taps and targets
Milestone
Originally raised in slack https://meltano.slack.com/archives/C01TCRBBJD7/p1688652938423919
The meltanolabs target-snowflake was throwing an error because its accepting the max length
4294967295
from the schema message as the varchar length which is larger than what snowflake accepts16777216
. It looks like currently we just pass that value through to sqlalchemy with no validation to limit it from being too large and ultimately the DDL fails.I'm going to fix it in target-snowflake but it does feel like something that should be handled by the SDK because its going to be relevant for most ever target. If we had a property method that needed to be implemented or a default class property that could be overridden. Another thing that might be worth checking out is if the sqlalchemy dialect package could tell us this generically somehow.
The text was updated successfully, but these errors were encountered: