-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Developers can now more easily override the mapping from SQL column type to JSON schema #2618
Merged
edgarrmondragon
merged 10 commits into
main
from
edgarrmondragon/feat/sqltype-to-json-schema-singledispatch
Sep 6, 2024
Merged
feat: Developers can now more easily override the mapping from SQL column type to JSON schema #2618
edgarrmondragon
merged 10 commits into
main
from
edgarrmondragon/feat/sqltype-to-json-schema-singledispatch
Sep 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #2618 will not alter performanceComparing Summary
|
edgarrmondragon
force-pushed
the
edgarrmondragon/feat/sqltype-to-json-schema-singledispatch
branch
3 times, most recently
from
August 21, 2024 21:07
d31b97c
to
a2f842a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2618 +/- ##
==========================================
+ Coverage 89.61% 89.82% +0.21%
==========================================
Files 58 58
Lines 4861 4884 +23
Branches 955 959 +4
==========================================
+ Hits 4356 4387 +31
+ Misses 352 346 -6
+ Partials 153 151 -2 ☔ View full report in Codecov by Sentry. |
edgarrmondragon
force-pushed
the
edgarrmondragon/feat/sqltype-to-json-schema-singledispatch
branch
6 times, most recently
from
August 21, 2024 22:32
39fe949
to
f91aff4
Compare
edgarrmondragon
added
Needs Documentation
kind/Feature
New feature or request
SQL
Support for SQL taps and targets
labels
Aug 21, 2024
…ON schema mapping
edgarrmondragon
force-pushed
the
edgarrmondragon/feat/sqltype-to-json-schema-singledispatch
branch
from
August 22, 2024 00:03
f91aff4
to
af47b26
Compare
edgarrmondragon
changed the title
feat: (WIP) Let developers more easily override SQL column type to JSON schema mapping
feat: Developers can now more easily override the mapping from SQL column type to JSON schema
Aug 22, 2024
edgarrmondragon
force-pushed
the
edgarrmondragon/feat/sqltype-to-json-schema-singledispatch
branch
from
August 24, 2024 19:22
601f4c8
to
ca2eab0
Compare
This was referenced Aug 28, 2024
edgarrmondragon
deleted the
edgarrmondragon/feat/sqltype-to-json-schema-singledispatch
branch
September 6, 2024 16:53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/Feature
New feature or request
Needs Documentation
Release Highlight
Call this out in the release notes
SQL
Support for SQL taps and targets
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
date
types causes schema validation to fail intarget-postgres
#1831maxLength
to schema MeltanoLabs/tap-postgres#485New docs links:
📚 Documentation preview 📚: https://meltano-sdk--2618.org.readthedocs.build/en/2618/