feat: Developers can now customize the default logging configuration for their taps/targets by adding default_logging.yml to their package
#2432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2432 +/- ##
=======================================
Coverage 89.41% 89.42%
=======================================
Files 58 58
Lines 4781 4783 +2
Branches 933 933
=======================================
+ Hits 4275 4277 +2
Misses 353 353
Partials 153 153 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #2432 will not alter performanceComparing Summary
|
edgarrmondragon
force-pushed
the
1373-feature-allow-application-developers-to-customize-logging-configuration
branch
2 times, most recently
from
5c184c6
to
d14cae1
Compare
edgarrmondragon
force-pushed
the
1373-feature-allow-application-developers-to-customize-logging-configuration
branch
from
d14cae1
to
ac3c46b
Compare
edgarrmondragon
force-pushed
the
1373-feature-allow-application-developers-to-customize-logging-configuration
branch
from
ac3c46b
to
1ef08ba
Compare
edgarrmondragon
force-pushed
the
1373-feature-allow-application-developers-to-customize-logging-configuration
branch
2 times, most recently
from
e6663e8
to
204f594
Compare
…for their taps/targets by overriding the `get_default_logging_config` method Related: * Closes #1373
edgarrmondragon
force-pushed
the
1373-feature-allow-application-developers-to-customize-logging-configuration
branch
from
204f594
to
75012ea
Compare
…-customize-logging-configuration
|
It might be better to expect the config file to be on a specific location within the package. |
edgarrmondragon
changed the title
get_default_logging_config methoddefault_logging.yml to their package
edgarrmondragon
changed the title
default_logging.yml to their packagedefault_logging.yml to their package
WillDaSilva
approved these changes
Jul 18, 2024
edgarrmondragon
deleted the
1373-feature-allow-application-developers-to-customize-logging-configuration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
📚 Documentation preview 📚: https://meltano-sdk--2432.org.readthedocs.build/en/2432/