Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add pattern, contentMediaType, and contentEncoding to Schema data class #1581

Merged
merged 4 commits into from
Apr 10, 2023
Merged

feat: Add pattern, contentMediaType, and contentEncoding to Schema data class #1581

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
233ccc6
add pattern, contentMediaType, contentEncoding to Schema data class
BuzzCutNorman Apr 3, 2023
9db25a9
Merge branch 'main' into feat-expand-schema-variables
edgarrmondragon Apr 4, 2023
0d9daf4
Merge branch 'main' into feat-expand-schema-variables
edgarrmondragon Apr 4, 2023
4d18a2b
Merge branch 'main' into feat-expand-schema-variables
edgarrmondragon Apr 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions singer_sdk/_singerlib/schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@
"type",
"required",
"enum",
"pattern",
"contentMediaType",
"contentEncoding",
# These are NOT simple keys (they can contain schemas themselves). We could
# consider adding extra handling to them.
"additionalProperties",
Expand Down Expand Up @@ -61,6 +64,9 @@ class Schema:
required: list[str] | None = None
enum: list[t.Any] | None = None
title: str | None = None
pattern: str | None = None
contentMediaType: str | None = None # noqa: N815
contentEncoding: str | None = None # noqa: N815

def to_dict(self) -> dict[str, t.Any]:
"""Return the raw JSON Schema as a (possibly nested) dict.
Expand Down