Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Force stream selection in tests #1698

Merged
merged 4 commits into from
Jun 19, 2023

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented May 11, 2023

Following #1672, tests (both --test and automatic pytest) fail to force selection of streams marked with selected_by_default = False. This PR addresses that.


📚 Documentation preview 📚: https://meltano-sdk--1698.org.readthedocs.build/en/1698/

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #1698 (3034013) into main (5a5f43a) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 3034013 differs from pull request most recent head 03d2f1c. Consider uploading reports for the commit 03d2f1c to get more accurate results

@@            Coverage Diff             @@
##             main    #1698      +/-   ##
==========================================
+ Coverage   85.69%   85.72%   +0.02%     
==========================================
  Files          59       59              
  Lines        4937     4896      -41     
  Branches      809      803       -6     
==========================================
- Hits         4231     4197      -34     
+ Misses        505      497       -8     
- Partials      201      202       +1     
Impacted Files Coverage Δ
singer_sdk/streams/core.py 83.33% <100.00%> (+0.11%) ⬆️
singer_sdk/tap_base.py 79.18% <100.00%> (+5.09%) ⬆️

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon force-pushed the fix/force-stream-selection-tests branch 2 times, most recently from c30dfa1 to d5b98bb Compare May 31, 2023 15:40
@edgarrmondragon edgarrmondragon marked this pull request as ready for review May 31, 2023 15:40
@edgarrmondragon edgarrmondragon force-pushed the fix/force-stream-selection-tests branch from d5b98bb to 301aa78 Compare June 5, 2023 18:31
@edgarrmondragon edgarrmondragon force-pushed the fix/force-stream-selection-tests branch from 301aa78 to cf6fc42 Compare June 5, 2023 23:34
@edgarrmondragon edgarrmondragon enabled auto-merge (squash) June 19, 2023 23:55
@edgarrmondragon edgarrmondragon merged commit 3e7f5b3 into main Jun 19, 2023
@edgarrmondragon edgarrmondragon deleted the fix/force-stream-selection-tests branch June 19, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants