feat(taps): End RESTStream pagination if an empty page is received #1918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1918 +/- ##
==========================================
+ Coverage 87.82% 87.84% +0.02%
==========================================
Files 60 60
Lines 4944 4953 +9
Branches 1007 1007
==========================================
+ Hits 4342 4351 +9
Misses 424 424
Partials 178 178 ☔ View full report in Codecov by Sentry. |
edgarrmondragon
changed the title
edgarrmondragon
changed the title
edgarrmondragon
force-pushed
the
feat/short-circuit-no-records-in-page
branch
from
c7775f0
to
7a2fbf7
Compare
CodSpeed Performance ReportMerging #1918 will not alter performanceComparing Summary
|
edgarrmondragon
force-pushed
the
feat/short-circuit-no-records-in-page
branch
from
7a2fbf7
to
a949bb7
Compare
edgarrmondragon
force-pushed
the
feat/short-circuit-no-records-in-page
branch
from
a949bb7
to
15494ab
Compare
edgarrmondragon
force-pushed
the
feat/short-circuit-no-records-in-page
branch
from
15494ab
to
3b9a7e0
Compare
edgarrmondragon
force-pushed
the
feat/short-circuit-no-records-in-page
branch
2 times, most recently
from
2688dd1
to
a26e9e3
Compare
edgarrmondragon
force-pushed
the
feat/short-circuit-no-records-in-page
branch
6 times, most recently
from
5a574fd
to
a35d411
Compare
edgarrmondragon
force-pushed
the
feat/short-circuit-no-records-in-page
branch
from
a35d411
to
f30edb6
Compare
edgarrmondragon
changed the title
edgarrmondragon
added a commit
to MeltanoLabs/tap-dbt
that referenced
this pull request
Jul 10, 2024
Should be possible with meltano/sdk#1918
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://meltano-sdk--1918.org.readthedocs.build/en/1918/