fix: Retry all 5xx status codes #2035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarrmondragon
changed the title
for more information, see https://pre-commit.ci
CodSpeed Performance ReportMerging #2035 will not alter performanceComparing Summary
|
edgarrmondragon
approved these changes
Nov 8, 2023
Wow, fastest merge ever! Thanks for accepting my PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for the
validate_responsefunction states that 5xx error codes should raise aRetriableAPIError.However, because
max(HTTPStatus)evaluates to 511, the current implementation does not raise the expected error for valid custom error codes such as Cloudflare's "521 Web Server Is Down".This PR removes the cap on
RetriableAPIErrorstatus codes so that valid custom error codes will raise the expected error.📚 Documentation preview 📚: https://meltano-sdk--2035.org.readthedocs.build/en/2035/