Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: converting floats to decimals before schema validation #2041

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions singer_sdk/helpers/_typing.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import datetime
import logging
import typing as t
from decimal import Decimal
from enum import Enum
from functools import lru_cache

Expand Down Expand Up @@ -491,3 +492,15 @@
if is_boolean_type(property_schema):
return None if elem is None else elem != 0
return elem

def float_to_decimal(value):
"""
Walk the given data structure and turn all instances of float into double.
"""
if isinstance(value, float):
return Decimal(str(value))

Check warning on line 501 in singer_sdk/helpers/_typing.py

View check run for this annotation

Codecov / codecov/patch

singer_sdk/helpers/_typing.py#L501

Added line #L501 was not covered by tests
if isinstance(value, list):
return [float_to_decimal(child) for child in value]
if isinstance(value, dict):
return {k: float_to_decimal(v) for k, v in value.items()}
return value
3 changes: 2 additions & 1 deletion singer_sdk/sinks/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
DatetimeErrorTreatmentEnum,
get_datelike_property_type,
handle_invalid_timestamp_in_record,
float_to_decimal,
)

if t.TYPE_CHECKING:
Expand Down Expand Up @@ -321,7 +322,7 @@ def _validate_and_parse(self, record: dict) -> dict:
Returns:
TODO
"""
self._validator.validate(record)
self._validator.validate(float_to_decimal(record))
self._parse_timestamps_in_record(
record=record,
schema=self.schema,
Expand Down