chore: Enable TRY and FLY Ruff rules
#2264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #2264 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2264 +/- ##
==========================================
+ Coverage 88.76% 88.98% +0.22%
==========================================
Files 54 54
Lines 4779 4767 -12
Branches 930 926 -4
==========================================
Hits 4242 4242
+ Misses 374 364 -10
+ Partials 163 161 -2 ☔ View full report in Codecov by Sentry. |
edgarrmondragon
force-pushed
the
edgarrmondragon/chore/enable-TRY-FLY-ruff-rules
branch
3 times, most recently
from
17bf5a6
to
0ef66a9
Compare
edgarrmondragon
force-pushed
the
edgarrmondragon/chore/enable-TRY-FLY-ruff-rules
branch
from
0ef66a9
to
5cd0a70
Compare
edgarrmondragon
commented
Apr 11, 2024
edgarrmondragon
commented
Apr 12, 2024
| if self.fail_on_record_validation_exception: | ||
| raise | ||
| self.logger.exception("Record validation failed %s", e) |
There was a problem hiding this comment.
This was flagged by Ruff's TRY401 as being redundant
edgarrmondragon
commented
Apr 12, 2024
Comment on lines
-925
to
-926
| except (AbortedSyncFailedException, AbortedSyncPausedException) as ex: | ||
| raise ex |
There was a problem hiding this comment.
This was also redundant
edgarrmondragon
deleted the
edgarrmondragon/chore/enable-TRY-FLY-ruff-rules
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://meltano-sdk--2264.org.readthedocs.build/en/2264/